-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
design: Add Secure Communication design doc #1186
Conversation
Updates projectcontour#881 Updates projectcontour#862 Signed-off-by: Nick Young <ynick@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
design/secure-communication.md
Outdated
|
||
## Security Considerations | ||
|
||
In the current design, these certs require the rolling of the deployment to change, they should be long-lived certs (days, weeks, or months), not short-lived (minutes or hours). The CA Keypair should be very long-lived and very tightly controlled, as Contour/Envoy connection security is only as secure as the CA keypair. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/these certs require the rolling of the deployment to change/the process must be restarted to pick a change to these certs/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Another future design might be to place Contour & Envoy in different namespaces as well to limit access to the envoy & contour secrets but doesn't change the design overall.
|
||
This applies both to Contour and Envoy. | ||
|
||
To accomplish this, we will add the following new command line options: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be nice to also plan about configuring these in the configuration file (#1130)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I think a note about which flags might move the config file is worth noting.
IMO not all of these flags will move to the config file, at the moment I'm only expecting that will be for things we pass to contour serve
. Some of those flags go to contour bootstrap
and will probably stay there as I'm not super keen in co-mingling contour bootstrap
configuration cli/flags with contour serve
s because the former is just an optional helper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did have a think about this, but figured that we'll just add them to the list of things that go in there when it gets started.
Signed-off-by: Nick Young <ynick@vmware.com>
Signed-off-by: Nick Young <ynick@vmware.com>
Signed-off-by: Nick Young <ynick@vmware.com>
Updates #881
Updates #862
Signed-off-by: Nick Young ynick@vmware.com